Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding updated OWNERS file #969

Merged
merged 3 commits into from
May 13, 2024

Conversation

fbm3307
Copy link
Contributor

@fbm3307 fbm3307 commented May 10, 2024

Adding updated OWNERS file as its required by prow

Similar PRs:

Signed-off-by: Feny Mehta <[email protected]>
OWNERS Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@fbm3307
Copy link
Contributor Author

fbm3307 commented May 13, 2024

e2e is stuck testing it again
/test e2e

reviewers:
- alexeykazakov
- MatousJobanek
- michaelkleinhenz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if @michaelkleinhenz still wants review our PRs? ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

he is added as CODEOWNER, so was trying to make OWNER file same as it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a miss, he is not there as codeowner.. so should we remove his name or keep his name here ?

Copy link

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alexeykazakov, fbm3307, mfrancisc, xcoulon

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexeykazakov alexeykazakov merged commit d1b75a5 into codeready-toolchain:master May 13, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants